Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement #1451

bergmeister · 2020-04-18T18:45:29Z

PR Summary

Formatter rules do not call APIs from VariableAnalysis, therefore skipping its initialization makes formatting much faster.
For PowerShell's 3000 line build.psm1 file, this changes execution time from 2 seconds to 1.5 seconds.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.


        Invoke-Formatter: Skip VariableAnalysis, which is not needed to yield…

… a 50% performance improvement

Invoke-Formatter: Skip VariableAnalysis, which is not needed to yield…

Loading status checks…

176874c

… a 50% performance improvement

bergmeister added Area - Formatter Area - Performance labels Apr 18, 2020

bergmeister requested review from rjmholt and JamesWTruher Apr 18, 2020

bergmeister changed the title ~~Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25%-50% performance improvement~~ Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement Apr 19, 2020

rjmholt approved these changes Apr 20, 2020

View changes

JamesWTruher approved these changes Apr 21, 2020

View changes

PowerShell / PSScriptAnalyzer

Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement #1451

Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement #1451

bergmeister commented Apr 18, 2020 •

edited

PowerShell / PSScriptAnalyzer

Join GitHub today

Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement #1451

Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement #1451

Conversation

bergmeister commented Apr 18, 2020 • edited

PR Summary

PR Checklist

bergmeister commented Apr 18, 2020 •

edited