Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use runtime expression syntax for passing pwsh parameter #1449

Merged

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Apr 17, 2020

PR Summary

This is due to a regression in Azure Pipelines expressions, which used to work the way they were but a few weeks ago they somehow changed their behaviour and now don't pass the parameter any more, meaning that the tests that were supposed to run on Windows PowerShell in the test matrix were actually run on PowerShell Core.
Changing to a run-time expression instead of a runtime expression for the moment to fix this
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#variables

I submitted this bug report: https://developercommunity.visualstudio.com/content/problem/996647/boolean-compile-time-yaml-expression-not-correctly.html

PR Checklist

@JamesWTruher
Copy link
Member

JamesWTruher commented Apr 21, 2020

@bergmeister could you resolve the merge conflict and resubmit?

@bergmeister
Copy link
Collaborator Author

bergmeister commented Apr 21, 2020

@JamesWTruher Sure. Done. It was a trivial conflict of the artificial EOL that GitHub always adds at the end of the file when using the web editor.

@bergmeister bergmeister merged commit 1f63688 into PowerShell:master Apr 24, 2020
12 checks passed
12 checks passed
PSScriptAnalyzer-CI Build #20200421.7 succeeded
Details
PSScriptAnalyzer-CI (Build Full_Build) Build Full_Build succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_16_04) Test Ubuntu_16_04 succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_18_04) Test Ubuntu_18_04 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1) Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core) Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1) Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core) Test Windows_Server2019_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_14_Mojave) Test macOS_10_14_Mojave succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_15_Catalina) Test macOS_10_15_Catalina succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.