Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCI: Use runtime expression syntax for passing pwsh parameter #1449
Conversation
|
@bergmeister could you resolve the merge conflict and resubmit? |
|
@JamesWTruher Sure. Done. It was a trivial conflict of the artificial EOL that GitHub always adds at the end of the file when using the web editor. |
1f63688
into
PowerShell:master
12 checks passed
12 checks passed
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1)
Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core)
Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1)
Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core)
Test Windows_Server2019_PowerShell_Core succeeded
Details
license/cla
All CLA requirements met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedApr 17, 2020
•
edited
PR Summary
This is due to a regression in Azure Pipelines expressions, which used to work the way they were but a few weeks ago they somehow changed their behaviour and now don't pass the parameter any more, meaning that the tests that were supposed to run on Windows PowerShell in the test matrix were actually run on PowerShell Core.
Changing to a run-time expression instead of a runtime expression for the moment to fix this
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#variables
I submitted this bug report: https://developercommunity.visualstudio.com/content/problem/996647/boolean-compile-time-yaml-expression-not-correctly.html
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.