Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ps7 syntax #1426

Merged
merged 2 commits into from Mar 31, 2020
Merged

Ps7 syntax #1426

merged 2 commits into from Mar 31, 2020

Conversation

@rjmholt
Copy link
Member

rjmholt commented Mar 11, 2020 •
edited

PR Summary

Waiting on #1425.

Adds syntax checking for new PowerShell 7 syntaxes.

PR Checklist
@rjmholt rjmholt requested review from bergmeister and JamesWTruher and removed request for bergmeister Mar 11, 2020
rjmholt added 2 commits Mar 11, 2020
@rjmholt
Add PS7 syntaxes to UseCompatibleSyntax rule
dc1e008
@rjmholt
Use correct ifdef constant
Loading status checks…
09d47c0
@rjmholt rjmholt force-pushed the rjmholt:ps7-syntax branch from 14ccfbe to 09d47c0 Mar 31, 2020
@rjmholt rjmholt marked this pull request as ready for review Mar 31, 2020
@rjmholt rjmholt requested a review from bergmeister Mar 31, 2020
@bergmeister
bergmeister approved these changes Mar 31, 2020
View changes
Copy link
Collaborator

bergmeister left a comment

LGTM if the tests comes back green as well :-)
@rjmholt rjmholt merged commit 2514855 into PowerShell:master Mar 31, 2020
12 checks passed
12 checks passed
PSScriptAnalyzer-CI Build #20200331.13 succeeded
Details
PSScriptAnalyzer-CI (Build Full_Build) Build Full_Build succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_16_04) Test Ubuntu_16_04 succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_18_04) Test Ubuntu_18_04 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1) Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core) Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1) Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core) Test Windows_Server2019_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_14_Mojave) Test macOS_10_14_Mojave succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_15_Catalina) Test macOS_10_15_Catalina succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
@bergmeister bergmeister mentioned this pull request May 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister

@JamesWTruher JamesWTruher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@rjmholt @bergmeister
You can’t perform that action at this time.