Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit CheckPipe feature of trimming redundant whitespace out into option CheckPipeForRedundantWhitespace #1413
Conversation
…ion CheckPipeForRedundantWhiteSpace
added 2 commits
Feb 10, 2020
|
|
||
| #### CheckPipeForRedundantWhitespace : bool (Default value is `$false`) | ||
|
|
||
| Checks if a pipe is surrounded by redundant whitespace (i.e. more than 1 whitespace). E.g. `foo | bar` instead of `foo|bar`. |
This comment has been minimized.
This comment has been minimized.
rjmholt
Feb 11, 2020
Member
Is the example here accurate? Or is it something like:
foo | barvs
foo | bar(GitHub seems to normalise spaces in inline code...)
This comment has been minimized.
This comment has been minimized.
bergmeister
Feb 11, 2020
Author
Collaborator
Yes, you're right, I forgot to update the example as well.
163d2c2
into
PowerShell:master
12 checks passed
12 checks passed
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1)
Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core)
Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1)
Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core)
Test Windows_Server2019_PowerShell_Core succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedFeb 10, 2020
•
edited
PR Summary
This is because some people align their pipes (e.g. in Pester tests) and don't want redundant white-space to be trimmed.
Therefore the concern of the rule options is split into 2 areas:
Checkpipestill corrects when there is no whitespace around the pipe operatorCheckPipeForRedundantWhiteSpaceoption is for cases where redundant whitespace needs to be trimmed. Disabled by default.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.