Skip to content

bpo-35960: Fix dataclasses.field throwing away empty metadata. #11815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2019
Merged

bpo-35960: Fix dataclasses.field throwing away empty metadata. #11815

merged 3 commits into from
Feb 12, 2019

Conversation

chrahunt
Copy link
Contributor

@chrahunt chrahunt commented Feb 11, 2019 •
edited by bedevere-bot
Loading

@chrahunt chrahunt requested a review from ericvsmith as a code owner February 11, 2019 02:08
remilapeyre
remilapeyre reviewed Feb 11, 2019
View reviewed changes
ericvsmith
ericvsmith reviewed Feb 11, 2019
View reviewed changes
@ericvsmith ericvsmith merged commit b01786c into python:master Feb 12, 2019
@miss-islington
Copy link
Contributor

Thanks @chrahunt for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2019
@chrahunt @miss-islington
bpo-35960: Fix dataclasses.field throwing away empty metadata. (pytho…
eece9bb 
…nGH-11815)

(cherry picked from commit b01786c)

Co-authored-by: Christopher Hunt <chrahunt@gmail.com>
@bedevere-bot
Copy link

GH-11826 is a backport of this pull request to the 3.7 branch.

ericvsmith pushed a commit that referenced this pull request Feb 12, 2019
@miss-islington @chrahunt @ericvsmith
bpo-35960: Fix dataclasses.field throwing away empty metadata. (GH-11815
0a834c1 
) (GH-11826)

(cherry picked from commit b01786c)

Co-authored-by: Christopher Hunt <chrahunt@gmail.com>
@chrahunt chrahunt deleted the fix/bpo-35960 branch February 12, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith left review comments

+2 more reviewers

@eamanu eamanu eamanu left review comments

@remilapeyre remilapeyre remilapeyre approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chrahunt @miss-islington @bedevere-bot @ericvsmith @eamanu @remilapeyre @the-knights-who-say-ni