GH-97592: Fix crash in C remove_done_callback due to evil code #97660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gvanrossum
commented
Sep 29, 2022
•
- Issue: Bugs in asyncio.Future.remove_done_callback() cause segfault. #97592
|
@xiaxinmeng Feel free to add your review. |
JelleZijlstra
approved these changes
Sep 30, 2022
kumaraditya303
reviewed
Sep 30, 2022
Misc/NEWS.d/next/Library/2022-09-29-23-22-24.gh-issue-97592.tpJg_J.rst
Outdated
Show resolved
Hide resolved
CharlieZhao95
suggested changes
Sep 30, 2022
| class evil: | ||
| def __eq__(self, other): | ||
| fut.remove_done_callback(other) | ||
|
|
||
| fut.remove_done_callback(evil()) |
There was a problem hiding this comment.
Class names should normally use the CapWords convention.
Suggested change
| class evil: | |
| def __eq__(self, other): | |
| fut.remove_done_callback(other) | |
| fut.remove_done_callback(evil()) | |
| class Evil: | |
| def __eq__(self, other): | |
| fut.remove_done_callback(other) | |
| fut.remove_done_callback(Evil()) |
| def __eq__(self, other): | ||
| fut.remove_done_callback(other) | ||
|
|
||
| fut.remove_done_callback(evil()) |
There was a problem hiding this comment.
All callbacks added by fut.add_done_callback() will be cleared when calling fut.remove_done_callback(Evil()), but the return value will be the number of callbacks added last.
I'm not sure if we need to improve the return value of remove done callback further, the current changes are good enough to fix the crash. :)
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
Thanks @gvanrossum for the PR |
|
GH-97692 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2022
…ythonGH-97660) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
|
GH-97693 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2022
…ythonGH-97660) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
miss-islington
added a commit
that referenced
this pull request
Sep 30, 2022
) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
miss-islington
added a commit
that referenced
this pull request
Sep 30, 2022
) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 2, 2022
…ython#97660) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.