Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33764: Appveyor fixes #7364

Merged
merged 3 commits into from Jun 4, 2018
Merged

bpo-33764: Appveyor fixes #7364

merged 3 commits into from Jun 4, 2018

Conversation

zware
Copy link
Member

@zware zware commented Jun 3, 2018 •
edited by bedevere-bot

@zware zware self-assigned this Jun 3, 2018
@zware
Copy link
Member Author

@zware zware commented Jun 3, 2018

It appears that AppVeyor is not accepting builds from us at the moment; I'm not sure why. I've tested this on my own clone (zware#8), though, and from a sample size of one it appears to both speed up the build and prevent the crash.

@terryjreedy if this comes unblocked and I haven't already done it, please feel free to merge.

@ned-deily ned-deily mentioned this pull request Jun 4, 2018
Closed
@vstinner vstinner changed the title Appveyor fixes bpo-33764: Appveyor fixes Jun 4, 2018
@vstinner
Copy link
Member

@vstinner vstinner commented Jun 4, 2018

I closed my PR #7368 as a duplicate of this one.

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 4, 2018

And now we cannot merge this PR because of https://bugs.python.org/issue33765 ? AppVeyor, you are not funny with us :-( Is a Python release manager allowed to merge such change? @ned-deily?

@ned-deily ned-deily merged commit 47a6c79 into python:master Jun 4, 2018
8 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 4, 2018

Thanks @zware for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 4, 2018

GH-7369 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2018
@zware @miss-islington
bpo-33764: Appveyor fixes (pythonGH-7364)
04bb87e 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
(cherry picked from commit 47a6c79)

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 4, 2018

Sorry, @zware and @ned-deily, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 47a6c79f0986ce9a84d0efc3c565b28255042911 2.7

@miss-islington miss-islington assigned ned-deily and unassigned zware Jun 4, 2018
@vstinner
Copy link
Member

@vstinner vstinner commented Jun 4, 2018

It would be nice to see a new AppVeyor build with this new configuration, before merging backports.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 4, 2018

Sorry, @zware and @ned-deily, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 47a6c79f0986ce9a84d0efc3c565b28255042911 3.6

ned-deily pushed a commit that referenced this issue Jun 4, 2018
@miss-islington @zware @ned-deily
bpo-33764: Appveyor fixes (GH-7364) (GH-7369)
37343a2 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
(cherry picked from commit 47a6c79)

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
ned-deily pushed a commit to ned-deily/cpython that referenced this issue Jun 4, 2018
@zware @ned-deily
bpo-33764: Appveyor fixes (pythonGH-7364)
0839542 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 4, 2018

GH-7379 is a backport of this pull request to the 3.6 branch.

ned-deily pushed a commit to ned-deily/cpython that referenced this issue Jun 4, 2018
@zware @ned-deily
bpo-33764: Appveyor fixes (pythonGH-7364)
a23f404 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 4, 2018

GH-7380 is a backport of this pull request to the 2.7 branch.

ned-deily added a commit that referenced this issue Jun 4, 2018
@ned-deily
bpo-33764: Appveyor fixes (GH-7364) (GH-7379)
b8f2fb5 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
ned-deily added a commit that referenced this issue Jun 4, 2018
@ned-deily
bpo-33764: Appveyor fixes (GH-7364) (GH-7380)
1cbdbf3 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
@zware zware deleted the appveyor_fixes branch Jun 22, 2018
lisroach pushed a commit to lisroach/cpython that referenced this issue Sep 10, 2018
@zware @lisroach
bpo-33764: Appveyor fixes (pythonGH-7364)
571be29 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this issue Nov 2, 2018
@zware @yahya-abou-imran
bpo-33764: Appveyor fixes (pythonGH-7364)
63032ab 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ned-deily ned-deily

Labels
CLA signed OS-windows skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zware @vstinner @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni