Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38918: Add __module__ entry for function & method type in inspect docs table #17408

Merged
merged 1 commit into from Dec 20, 2019
Merged

bpo-38918: Add __module__ entry for function & method type in inspect docs table #17408

merged 1 commit into from Dec 20, 2019

Conversation

parthsharma2
Copy link
Contributor

@parthsharma2 parthsharma2 commented Nov 27, 2019 •
edited by miss-islington

Adds__module__ entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918

Automerge-Triggered-By: @ericsnowcurrently

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Nov 27, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@parthsharma2

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 27, 2019
@parthsharma2
Copy link
Contributor Author

parthsharma2 commented Nov 28, 2019

Should I make a news entry in Misc/NEWS.d/next?

@ericsnowcurrently ericsnowcurrently self-requested a review Dec 13, 2019
ericsnowcurrently
ericsnowcurrently approved these changes Dec 13, 2019
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM

Just make sure to add a NEWS entry. See: https://devguide.python.org/committing/#what-s-new-and-news-entries

@parthsharma2
Copy link
Contributor Author

parthsharma2 commented Dec 15, 2019

@ericsnowcurrently added a NEWS entry

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Dec 20, 2019

close-and-reopen to force checks to re-run.

@ericsnowcurrently ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 20, 2019
@miss-islington miss-islington merged commit f522a6d into python:master Dec 20, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Dec 20, 2019

Thanks @parthsharma2 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Dec 20, 2019

Thanks @parthsharma2 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 20, 2019

GH-17675 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2019
@parthsharma2 @miss-islington
bpo-38918: Add __module__ entry for function & method type in inspect…
72f929a 
… docs table (pythonGH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 20, 2019

GH-17676 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2019
@parthsharma2 @miss-islington
bpo-38918: Add __module__ entry for function & method type in inspect…
e328300 
… docs table (pythonGH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 20, 2019
@miss-islington @parthsharma2
bpo-38918: Add __module__ entry for function & method type in inspect…
0ffc900 
… docs table (GH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 20, 2019
@miss-islington @parthsharma2
bpo-38918: Add __module__ entry for function & method type in inspect…
44683bb 
… docs table (GH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
@sthagen sthagen mentioned this pull request Dec 20, 2019
Merged
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@parthsharma2 @shihai1991
bpo-38918: Add __module__ entry for function & method type in inspect…
7d0f2fb 
… docs table (pythonGH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.





https://bugs.python.org/issue38918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@parthsharma2 @the-knights-who-say-ni @ericsnowcurrently @miss-islington @bedevere-bot