Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33961: Adjusted dataclasses docs to correct exceptions raised. (GH-7917) #17677

Merged
merged 1 commit into from Dec 25, 2019
Merged

bpo-33961: Adjusted dataclasses docs to correct exceptions raised. (GH-7917) #17677

merged 1 commit into from Dec 25, 2019

Conversation

sanjioh
Copy link
Contributor

@sanjioh sanjioh commented Dec 21, 2019 •
edited by bedevere-bot

This PR adds a cherry-picked commit from a PR merged by mistake into 3.7 instead of into master - see #7917 for details.
This needs to be backported to 3.8 as well.

https://bugs.python.org/issue33961

@sanjioh sanjioh requested a review from ericvsmith as a code owner Dec 21, 2019
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Dec 21, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sanjioh

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 21, 2019
@sanjioh sanjioh mentioned this pull request Dec 21, 2019
Merged
aeros
aeros approved these changes Dec 25, 2019
View changes
Copy link
Member

@aeros aeros left a comment

Thanks for the PR @sanjioh and welcome!

This looks the exactly same as https://github.com/python/cpython/pull/7917/files, but against the master branch (as expected). I'll add the label for backporting it to 3.8. LGTM.

@ericvsmith ericvsmith merged commit e28aff5 into python:master Dec 25, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Dec 25, 2019

Thanks @sanjioh for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 25, 2019

GH-17705 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Dec 25, 2019
@miss-islington @sanjioh
bpo-33961: Adjusted dataclasses docs to correct exceptions raised. (G…
a5deabd 
…H-7917) (GH-17677)

(cherry picked from commit e28aff5)

Co-authored-by: Fabio Sangiovanni <4040184+sanjioh@users.noreply.github.com>
@sthagen sthagen mentioned this pull request Dec 26, 2019
Merged
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@sanjioh @shihai1991
bpo-33961: Adjusted dataclasses docs to correct exceptions raised. (p…
e129f4a 
…ythonGH-7917) (pythonGH-17677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeros aeros

@ericvsmith ericvsmith

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sanjioh @the-knights-who-say-ni @miss-islington @bedevere-bot @aeros @ericvsmith @chmarr