Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the esoteric term 'datum' when describing dict comprehensions #106119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace the esoteric term 'datum' when describing dict comprehensions #106119

wants to merge 1 commit into from
+12 鈭�12

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Jun 26, 2023 •
edited by github-actions bot

馃摎 Documentation preview 馃摎: https://cpython-previews--106119.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 26, 2023
@SnoopJ
Copy link
Contributor

SnoopJ commented Jun 26, 2023 •
edited

This PR originates from an IRC discussion in #python on Libera.chat wherein a user was confused about the mix-and-match usage of key/value and key/datum in the official documentation.

Also worth considering as a potentially confusing ambiguity: there are several places in the docs that use the expression key value when referring to an object that is being used as a key.

Edit: Fun trivia: this language dates to the 1991 draft of the Language Reference, the term first appeared in f2612d1 by my reckoning.

JelleZijlstra
JelleZijlstra approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. "datum" is unnecessarily obscure.

I'll leave this open for some time in case others have comments.

@JelleZijlstra JelleZijlstra added needs backport to 3.11 bug and security fixes needs backport to 3.12 bug and security fixes and removed awaiting merge labels Jun 26, 2023
@JelleZijlstra JelleZijlstra self-assigned this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir needs backport to 3.11 bug and security fixes needs backport to 3.12 bug and security fixes skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nedbat @SnoopJ @JelleZijlstra @bedevere-bot