Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-3530: Use fix_missing_locations when node transformer adds nodes #17172

Merged
merged 6 commits into from Jan 12, 2020
Merged

bpo-3530: Use fix_missing_locations when node transformer adds nodes #17172

merged 6 commits into from Jan 12, 2020

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Nov 15, 2019 •
edited by miss-islington

Remove misleading (inadequate) suggestion from example.

https://bugs.python.org/issue3530

Automerge-Triggered-By: @pablogsal

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 15, 2019
@terryjreedy terryjreedy changed the title bpo-3530: advice fix_missing_locations usage on new node introduction bpo-3530: use fix_missing_locations when adding nodes Nov 17, 2019
@terryjreedy terryjreedy changed the title bpo-3530: use fix_missing_locations when adding nodes bpo-3530: Use fix_missing_locations when node transformer adds nodes Nov 17, 2019
@terryjreedy
Copy link
Member

terryjreedy commented Nov 17, 2019

@isidentical Please add news item with blurb or blurb-it(sp?). Suggestion:
In ast doc, fix misleading NodeTransformer example and add fix_missing_locations advice.

@csabella csabella requested a review from pablogsal Jan 12, 2020
@pablogsal pablogsal self-assigned this Jan 12, 2020
pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Doc/library/ast.rst Outdated Show resolved Hide resolved
@isidentical @pablogsal
Apply suggestions from code review
2b827c8 
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Doc/library/ast.rst Show resolved Hide resolved
pablogsal
pablogsal approved these changes Jan 12, 2020
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM! Great work! 🎉

@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jan 12, 2020
@pablogsal pablogsal removed the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jan 12, 2020
@isidentical @pablogsal
Update Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8z…
f412471 
…FUMc.rst

Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal merged commit 6680f4a into python:master Jan 12, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jan 12, 2020

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
@isidentical @miss-islington
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
e1b1801 
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 12, 2020

GH-17972 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
@isidentical @miss-islington
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
ec54571 
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 12, 2020

GH-17973 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 12, 2020
@miss-islington @isidentical
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
e222b4c 
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 12, 2020
@miss-islington @isidentical
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
ef0af30 
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@isidentical @pablogsal @shihai1991
bpo-3530: Add advice on when to correctly use fix_missing_locations i…
51ca4e2 
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@tirkarthi tirkarthi mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@benjaminp benjaminp

@brettcannon brettcannon

Assignees

@pablogsal pablogsal

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@isidentical @terryjreedy @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni @csabella