gh-96168: Improve sqlite3 dict_factory example #96457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use dict comprehension - use doctest iso. testcode, for visualising the effect of the row factory - SELECT with multiple columns, so the effect of the row factory becomes clearer
ezio-melotti
reviewed
Aug 31, 2022
ezio-melotti
approved these changes
Aug 31, 2022
CAM-Gerlach
reviewed
Sep 1, 2022
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
Thanks for the reviews, CAM & Ezio! |
|
Thanks @erlend-aasland for the PR |
|
GH-96494 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 1, 2022
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 91f40f3) Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
|
GH-96495 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 1, 2022
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 91f40f3) Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington
added a commit
that referenced
this pull request
Sep 1, 2022
miss-islington
added a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
effect of the row factory
the row factory becomes clearer