Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Datastructures Review. #148

Merged
merged 2 commits into from Feb 6, 2018

Conversation

@christopheNan
Copy link
Collaborator

christopheNan commented Feb 5, 2018

No description provided.

Copy link
Member

JulienPalard left a comment

Thanks for the review but I spotted a few changes in msgid.

"insert(len(a), x)`` est équivalent à ``a.append(x)``."

#: ../Doc/tutorial/datastructures.rst:43
msgid ""
"Remove the first item from the list whose value is *x*. It is an error if "
"there is no such item."
"Remove the first item from the list whose value is equal to *x*. It is an "

This comment has been minimized.

@JulienPalard

JulienPalard Feb 5, 2018

Member

Why is the msgid changed here?

This comment has been minimized.

@christopheNan

christopheNan Feb 6, 2018

Author Collaborator

Je ne sais pas ! j'ai "joué" avec make merge et git pull dans cpython. J'essaie de reproduire...


#: ../Doc/tutorial/datastructures.rst:66
msgid ""
"Return zero-based index in the list of the first item whose value is *x*. "
"Raises a :exc:`ValueError` if there is no such item."
"Return zero-based index in the list of the first item whose value is equal "

This comment has been minimized.

@JulienPalard

JulienPalard Feb 5, 2018

Member

Same here.

@JulienPalard JulienPalard merged commit d71a11b into python:3.6 Feb 6, 2018
@christopheNan christopheNan deleted the christopheNan:tutorialdatastruct branch Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.