Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44958: Fix ref. leak introduced in GH-27844 #28490

Merged
merged 2 commits into from Sep 21, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 21, 2021

Modify managed_connect() helper to support in-memory databases. Use it
for the regression tests added in GH-27844.

https://bugs.python.org/issue44958

Automerge-Triggered-By: GH:pablogsal

Erlend E. Aasland added 2 commits Sep 21, 2021
Modify managed_connect() helper to support in-memory databases. Use it
for the regression tests added in pythonGH-27844.
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2021
@erlend-aasland erlend-aasland requested a review from pablogsal Sep 21, 2021
@erlend-aasland erlend-aasland changed the title bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select() bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select Sep 21, 2021
@erlend-aasland erlend-aasland changed the title bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select bpo-44958: Fix ref. leak introduced in GH-27844 Sep 21, 2021
@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Sep 21, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Sep 21, 2021

@erlend-aasland: Status check is done, and it's a success .

@miss-islington miss-islington merged commit 3e3ff09 into python:main Sep 21, 2021
11 checks passed
@erlend-aasland erlend-aasland deleted the sqlite-fix-refleak branch Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants