Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45723: Detect missing pkg-config (GH-29442) #29442

Merged
merged 4 commits into from Nov 7, 2021
Merged

bpo-45723: Detect missing pkg-config (GH-29442) #29442

merged 4 commits into from Nov 7, 2021

Conversation

@tiran
Copy link
Member

@tiran tiran commented Nov 6, 2021 •
edited by bedevere-bot

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45723
@tiran tiran requested review from ned-deily and pablogsal Nov 6, 2021
@tiran tiran changed the title Detect missing pkg-config bpo-45723: Detect missing pkg-config Nov 6, 2021
pablogsal
pablogsal reviewed Nov 6, 2021
View changes
configure Outdated Show resolved Hide resolved
@tiran tiran force-pushed the bpo-45723-pkgconf branch from af36054 to 2fa083d Nov 6, 2021
ned-deily
ned-deily reviewed Nov 6, 2021
View changes
Copy link
Member

@ned-deily ned-deily left a comment

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

@ned-deily
Copy link
Member

@ned-deily ned-deily commented Nov 6, 2021 

[...]
config.status: creating pyconfig.h
creating Modules/Setup.local
creating Makefile

pkg-config is missing. Some dependencies may not be detected correctly.


If you want a release build with all stable optimizations active (PGO, etc),
please run ./configure --enable-optimizations


$ pkg-config
Must specify package names on the command line
$ which pkg-config
/usr/bin/pkg-config

This is on a reasonably vanilla Debian system. Also the same on macOS with pkg-config installed from MacPorts.

@tiran
Copy link
Member Author

@tiran tiran commented Nov 6, 2021 •
edited

Strange ... could you please paste the output of grep PKG_CONFIG config.log ?

My system (Fedora 34):

$ grep PKG_CONFIG config.log 
ac_cv_env_PKG_CONFIG_LIBDIR_set=
ac_cv_env_PKG_CONFIG_LIBDIR_value=
ac_cv_env_PKG_CONFIG_PATH_set=
ac_cv_env_PKG_CONFIG_PATH_value=
ac_cv_env_PKG_CONFIG_set=
ac_cv_env_PKG_CONFIG_value=
ac_cv_path_ac_pt_PKG_CONFIG=/usr/bin/pkg-config
ac_cv_prog_ac_ct_PKG_CONFIG=/usr/bin/pkg-config
PKG_CONFIG='/usr/bin/pkg-config'
PKG_CONFIG_LIBDIR=''
PKG_CONFIG_PATH=''

@tiran
Copy link
Member Author

@tiran tiran commented Nov 6, 2021

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

AC_PATH_TOOL is provided by autoconf/programs.m4.

@tiran
Copy link
Member Author

@tiran tiran commented Nov 6, 2021

D'oh, I put test -n to test the output message and forgot to replace it with test -z.

@tiran tiran marked this pull request as ready for review Nov 6, 2021
@tiran tiran force-pushed the bpo-45723-pkgconf branch from 8c59d49 to 3061c4b Nov 7, 2021
@tiran tiran changed the title bpo-45723: Detect missing pkg-config bpo-45723: Detect missing pkg-config (GH-29442) Nov 7, 2021
@tiran tiran merged commit be3cd5c into python:main Nov 7, 2021
12 checks passed
@tiran tiran deleted the bpo-45723-pkgconf branch Nov 7, 2021
remykarem added a commit to remykarem/cpython that referenced this issue Dec 7, 2021
@tiran @remykarem
bpo-45723: Detect missing pkg-config (pythonGH-29442)
3c415d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@ned-deily ned-deily

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@tiran @ned-deily @pablogsal @the-knights-who-say-ni @bedevere-bot