`_PyTrash_begin` and `_PyTrash_end` do not have implementation

We only have this left for `_PyTrash_begin` and `_PyTrash_end`:

```
~/Desktop/cpython2  main ✗                                                                
» ag _PyTrash_begin .
Misc/NEWS.d/3.9.0a5.rst
1217:PyThreadState attributes, but call new private _PyTrash_begin() and

Include/cpython/object.h
479:PyAPI_FUNC(int) _PyTrash_begin(PyThreadState *tstate, PyObject *op);
```

```
» ag _PyTrash_end .  
Misc/NEWS.d/3.9.0a5.rst
1218:_PyTrash_end() functions which hide implementation details.

Include/cpython/object.h
480:PyAPI_FUNC(void) _PyTrash_end(PyThreadState *tstate);                  
```

Source: https://github.com/python/cpython/blob/313b96eb8b8d0ad3bac58d633822a0a3705ce60b/Include/cpython/object.h#L478-L481

They don't even have implementations. Looks like that they used to be called from `Py_TRASHCAN_BEGIN` and `Py_TRASHCAN_END` in 3.9: https://github.com/python/cpython/blob/340a82d9cff7127bb5a777d8b9a30b861bb4beee/Include/cpython/object.h#L520-L545

But, they are unused since https://github.com/python/cpython/pull/117763 in ~3.11

What should we do?
1. Nothing
2. Remove them
3. Raise deprecation warning when they are called (but they return `void`, it would be hard to do)

CC @markshannon @vstinner 


### Linked PRs
* gh-128919

	PyAPI_FUNC(int) _PyTrash_begin(struct _ts tstate, PyObject op);
	PyAPI_FUNC(void) _PyTrash_end(struct _ts *tstate);

	#define PyTrash_UNWIND_LEVEL 50

	#define Py_TRASHCAN_BEGIN_CONDITION(op, cond) \
	do { \
	PyThreadState *_tstate = NULL; \
	/* If "cond" is false, then _tstate remains NULL and the deallocator \
	* is run normally without involving the trashcan */ \
	if (cond) { \
	_tstate = PyThreadState_GET(); \
	if (_PyTrash_begin(_tstate, _PyObject_CAST(op))) { \
	break; \
	} \
	}
	/* The body of the deallocator is here. */
	#define Py_TRASHCAN_END \
	if (_tstate) { \
	_PyTrash_end(_tstate); \
	} \
	} while (0);

	#define Py_TRASHCAN_BEGIN(op, dealloc) \
	Py_TRASHCAN_BEGIN_CONDITION(op, \
	Py_TYPE(op)->tp_dealloc == (destructor)(dealloc))

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

`_PyTrash_begin` and `_PyTrash_end` do not have implementation #128910

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	/* Python 3.9 private API, invoked by the macros below. */
	PyAPI_FUNC(int) _PyTrash_begin(PyThreadState tstate, PyObject op);
	PyAPI_FUNC(void) _PyTrash_end(PyThreadState *tstate);

Uh oh!

_PyTrash_begin and _PyTrash_end do not have implementation #128910

Description

Linked PRs

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`_PyTrash_begin` and `_PyTrash_end` do not have implementation #128910