Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher #99386

Merged
merged 3 commits into from Nov 12, 2022
Merged

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher #99386

merged 3 commits into from Nov 12, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 11, 2022 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Nov 11, 2022
Open
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Nov 11, 2022 •
edited

This isn't really needed as deprecation warning will be emitted anyway when configuring the child watcher via set_child_watcher but still adding for anyone who is subclassing this but not configuring the child watcher for whatever reason.

@kumaraditya303 kumaraditya303 mentioned this pull request Nov 11, 2022
Closed
gvanrossum
gvanrossum approved these changes Nov 11, 2022
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

(Do double check the appearance of the deprecation note.)

Doc/library/asyncio-policy.rst Show resolved Hide resolved
@gvanrossum gvanrossum merged commit aa87432 into python:main Nov 12, 2022
15 checks passed
@kumaraditya303 kumaraditya303 deleted the async-deprecate branch Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@1st1 1st1

@asvetlov asvetlov

Assignees
No one assigned
Labels
expert-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kumaraditya303 @gvanrossum @bedevere-bot