Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46968: Check for 'sys/auxv.h' in the configure script #31961

Merged
merged 3 commits into from
Mar 18, 2022
Merged

bpo-46968: Check for 'sys/auxv.h' in the configure script #31961

merged 3 commits into from
Mar 18, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 17, 2022 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from vstinner March 17, 2022 14:25
pablogsal
pablogsal commented Mar 17, 2022
View reviewed changes
Modules/faulthandler.c Outdated Show resolved Hide resolved
@oleksandr-pavlyk
Copy link
Contributor

Sorry about the issue. I was thinking of adding the test but then assumed existence of linux/auxvec.h implies existence of sys/auxv.h based on inspection of recent kernels.

vstinner
vstinner approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Modules/faulthandler.c Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

Sorry about the issue. I was thinking of adding the test but then assumed existence of linux/auxvec.h implies existence of sys/auxv.h based on inspection of recent kernels.

Same here. But the Linux ecosystem is always more complicated than what I expect :-)

@pablogsal @vstinner
Update Modules/faulthandler.c
1488358 
Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8e3fde7 into python:main Mar 18, 2022
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e3fde728f547f1d32bde8adf62b4c50bb877b9d 3.10

@miss-islington miss-islington self-assigned this Mar 18, 2022
@miss-islington
Copy link
Contributor

Sorry @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e3fde728f547f1d32bde8adf62b4c50bb877b9d 3.9

pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 18, 2022
@pablogsal
[3.10] bpo-46968: Check for 'sys/auxv.h' in the configure script (pyt…
000dabd 
…honGH-31961).

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 18, 2022
@pablogsal
[3.9] bpo-46968: Check for 'sys/auxv.h' in the configure script (pyth…
b66af27 
…onGH-31961).

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 18, 2022
@bedevere-bot
Copy link

GH-31975 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit that referenced this pull request Mar 18, 2022
@pablogsal
[3.9] bpo-46968: Check for 'sys/auxv.h' in the configure script (GH-3…
a12ef81 
…1961). (GH-31975)

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Mar 18, 2022
@pablogsal
[3.10] bpo-46968: Check for 'sys/auxv.h' in the configure script (GH-…
6fd9737 
…31961). (GH-31974)

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@pablogsal @hello-adam
[3.9] bpo-46968: Check for 'sys/auxv.h' in the configure script (pyth…
76e6e43 
…onGH-31961). (pythonGH-31975)

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees

@miss-islington miss-islington

Labels
needs backport to 3.10 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @oleksandr-pavlyk @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni