Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Doc/README.txt to Doc/README.rst #18

Closed
wants to merge 7 commits into from
Closed

Rename Doc/README.txt to Doc/README.rst #18

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2017

I have simply updated the document and its references to README.rst (thanks to whoever formatted it).

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Feb 11, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@ghost ghost changed the title Rename README.txt to README.rst Rename Doc/README.txt to Doc/README.rst Feb 11, 2017
@ghost
Copy link
Author

@ghost ghost commented Feb 11, 2017

I have signed the CLA, so the PR will take a day for approval

@methane
Copy link
Member

@methane methane commented Feb 11, 2017

@rogersachan master branch already renamed README.txt -> README.rst
Please rebase your branch.

@ghost
Copy link
Author

@ghost ghost commented Feb 11, 2017

I accidentally merged and destroyed this PR, so I'll close it now.

P.S. The extra option next to the merge button would have let you rebase it but ¯_(ツ)_/¯

@ghost ghost closed this Feb 11, 2017
@willingc
Copy link
Sponsor Contributor

@willingc willingc commented Feb 11, 2017

Hi @rogersachan,

Thanks for the PR. It's common practice in open source for the contributor to rebase their submission instead of the maintainer doing it. By the contributor doing the rebase, it makes things more efficient for multiple reviewers. 👍

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants