Skip to content

/ miss-islington

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip backport PR number from the commit message #53

Closed
berkerpeksag opened this issue Feb 12, 2018 · 2 comments
Closed

Strip backport PR number from the commit message #53

berkerpeksag opened this issue Feb 12, 2018 · 2 comments

Comments

@berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Feb 12, 2018

From https://devguide.python.org/gitbootcamp/#backporting-merged-changes

Example of good backport commit message:

bpo-12345: Improve the spam module (GH-777)

  • Add method A to the spam module
  • Update the documentation of the spam module

(cherry picked from commit 62adc55)

I agree that the backport PR's number is rarely useful and it would be nice to remove it automatically. Can miss-islington strip the backport PR number in the commit message?
Mariatta added a commit to Mariatta/miss-islington that referenced this issue Feb 12, 2018
@Mariatta
Remove the backport PR number, retain the original PR number
81aa5c3 
Closes python#53
@Mariatta Mariatta mentioned this issue Feb 12, 2018
Merged
@Mariatta
Copy link
Member

@Mariatta Mariatta commented Feb 12, 2018

Yes, done in #53.
@berkerpeksag
Copy link
Member Author

@berkerpeksag berkerpeksag commented Feb 12, 2018

Awesome, thank you very much @Mariatta :)
@Mariatta Mariatta closed this in #56 Feb 12, 2018
Mariatta added a commit that referenced this issue Feb 12, 2018
@Mariatta
Remove the backport PR number, retain the original PR number (GH-56)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6b826d3 
Closes #53
@Mariatta Mariatta mentioned this issue Sep 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@berkerpeksag @Mariatta
You can’t perform that action at this time.