Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installers to Tcl/Tk 8.6.14 #116145

Open
chrstphrchvz opened this issue Feb 29, 2024 · 8 comments
Open

Update installers to Tcl/Tk 8.6.14 #116145

chrstphrchvz opened this issue Feb 29, 2024 · 8 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes

Comments

@chrstphrchvz
Copy link
Contributor

chrstphrchvz commented Feb 29, 2024 •
edited by bedevere-app bot

Tcl/Tk 8.6.14 is out today: https://sourceforge.net/p/tcl/mailman/tcl-core/thread/SA1PR09MB887585E09B30AE57F0E7F2E3865F2%40SA1PR09MB8875.namprd09.prod.outlook.com/#msg58743251

I will open a few PRs for these shortly: one here for the macOS installer, and others at cpython-source-deps for Windows:
python/cpython-source-deps#33
python/cpython-source-deps#34

There is still a known test failure with Tk 8.6.14 which I have neglected: gh-107262

Linked PRs
This was referenced Feb 29, 2024
Closed
Closed
@bedevere-app bedevere-app bot mentioned this issue Feb 29, 2024
Merged
chrstphrchvz added a commit to chrstphrchvz/cpython that referenced this issue Feb 29, 2024
@chrstphrchvz
pythongh-116145: Update macOS installer to Tcl/Tk 8.6.14
734cb44
ned-deily pushed a commit that referenced this issue Mar 12, 2024
@chrstphrchvz
gh-116145: Update macOS installer to Tcl/Tk 8.6.14 (GH-116151)
4fa95c6
@hugovk
Copy link
Member

hugovk commented Mar 15, 2024

The linked PR is merged, is there more to do or can this issue be closed? Thanks!

@ned-deily
Copy link
Member

The linked PR is merged, is there more to do or can this issue be closed? Thanks!

I believe the Windows build needs to be updated to use the new version (PCbuild/get_externals.bat and PCbuild/tcltk.props). @zooba @zware

@zooba
Copy link
Member

zooba commented Mar 19, 2024

Yeah, Windows is not done yet. I should have time later today to bring in the new sources and set the build up.

@bedevere-app bedevere-app bot mentioned this issue Mar 19, 2024
Merged
zooba added a commit to zooba/cpython that referenced this issue Mar 19, 2024
@zooba
pythongh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14
793ed7f
@zooba
Copy link
Member

zooba commented Mar 19, 2024

It looks like something has changed in Tkinter as a result of the new version. @terryjreedy is this something you can look into? You can see the build results on #117030

adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@chrstphrchvz @adorilson
pythongh-116145: Update macOS installer to Tcl/Tk 8.6.14 (pythonGH-11…
fdeb67e 
…6151)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@chrstphrchvz @diegorusso
pythongh-116145: Update macOS installer to Tcl/Tk 8.6.14 (pythonGH-11…
5dd4b4f 
…6151)
@DBJim DBJim mentioned this issue May 21, 2024
Merged
serhiy-storchaka added a commit to zooba/cpython that referenced this issue May 30, 2024
@serhiy-storchaka
Merge branch 'main' into pythongh-116145
4bb20bd
zooba added a commit that referenced this issue May 31, 2024
@zooba
gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 (GH-117030)
0e8d35b
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 31, 2024
@zooba @miss-islington
pythongh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 (pythonG…
92402f9 
…H-117030)

(cherry picked from commit 0e8d35b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app bedevere-app bot mentioned this issue May 31, 2024
Merged
@serhiy-storchaka serhiy-storchaka added 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels May 31, 2024
zooba added a commit that referenced this issue May 31, 2024
@miss-islington @zooba
gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 (GH-117030)
6e57bd0 
(cherry picked from commit 0e8d35b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@terryjreedy
Copy link
Member

@zooba I have no record or recollection of receiving your Mar 20 note. I just read the release announcement and don't see any problem at least with IDLE. I will do some manual testing after updating. Glad to see update in both 3.13 and 3.14. Fine to leave 3.12 alone.

@serhiy-storchaka
Copy link
Member

8.6.14 is a bugfix release, and it can contain changes affecting Tkinter users. https://wiki.tcl-lang.org/page/Changes+in+Tcl%2FTk+8%2E6%2E14

Is there a way for Windows and macOS users to update Tcl/Tk separately? If they can only use the version shipped with Python, we should provide the last stable bugfix release.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 1, 2024
@chrstphrchvz @miss-islington
pythongh-116145: Update macOS installer to Tcl/Tk 8.6.14 (pythonGH-11…
8629058 
…6151)

(cherry picked from commit 4fa95c6)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@bedevere-app bedevere-app bot mentioned this issue Jun 1, 2024
Merged
@ned-deily
Copy link
Member

If they can only use the version shipped with Python, we should provide the last stable bugfix release.

Thanks for the reminder, @serhiy-storchaka. This should have been backported earlier to 3.12.x for the macOS installer but I guess I was waiting to see if any issues arose with the 3.13 alphas. PR #119922 will be merged for the upcoming 3.12.4 release.

ned-deily pushed a commit that referenced this issue Jun 1, 2024
@miss-islington
[3.12] gh-116145: Update macOS installer to Tcl/Tk 8.6.14 (GH-116151) (…
46545d3 
…GH-119922)

(cherry picked from commit 4fa95c6)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@aivarannamaa
Copy link
Contributor

The discussion under PR-s is confusing for me, so I'll ask here -- is Tcl/Tk 8.6.14 coming for Python 3.12 Windows installers? 3.12.4 seems to be still with 8.6.13.

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this issue Jun 12, 2024
@zooba @serhiy-storchaka
[3.12] pythongh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 (p…
2f8c34f 
…ythonGH-117030)

(cherry picked from commit 0e8d35b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app bedevere-app bot mentioned this issue Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@aivarannamaa @hugovk @zooba @serhiy-storchaka @ned-deily @chrstphrchvz @terryjreedy