Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that tests results file gets uploaded in CI when there is a test failure #1455

Merged
merged 1 commit into from Apr 20, 2020

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Apr 20, 2020

PR Summary

Due to too much indentation condition was not applied, I did test in another branch that in case there is a test failure, it actually works.
And that my friends is why I (don't) love yaml....
https://noyaml.com/

PR Checklist

…, condition was not applied
@bergmeister bergmeister requested review from rjmholt and JamesWTruher Apr 20, 2020
@bergmeister bergmeister changed the title Make sure that tests results file always get uploaded in CI (due to too much indentation condition was not applied) Make sure that tests results file also gets uploaded in CI when there is a test failure Apr 20, 2020
@bergmeister bergmeister changed the title Make sure that tests results file also gets uploaded in CI when there is a test failure Make sure that tests results file gets uploaded in CI when there is a test failure Apr 20, 2020
Copy link
Member

JamesWTruher left a comment

lgtm

@bergmeister bergmeister merged commit 5158f4f into PowerShell:master Apr 20, 2020
12 checks passed
12 checks passed
PSScriptAnalyzer-CI Build #20200420.2 succeeded
Details
PSScriptAnalyzer-CI (Build Full_Build) Build Full_Build succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_16_04) Test Ubuntu_16_04 succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_18_04) Test Ubuntu_18_04 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1) Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core) Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1) Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core) Test Windows_Server2019_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_14_Mojave) Test macOS_10_14_Mojave succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_15_Catalina) Test macOS_10_15_Catalina succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.