Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLazy initialisation of LinkedList in TokenOperations constructor -> 7% performance gain for formatter #1453
Conversation
|
Awesome! |
|
Also, is there a good reason to use a linked list here? Surely it should just be a |
When you look at the callers, they use the |
022009b
into
PowerShell:master
bergmeister commentedApr 18, 2020
•
edited
PR Summary
This is a simple optimizaton as many consumers that construct the
TokenOperationsclass do not call APIs that use the LinkedList. This changes the CPU consumption of this class constructor during a format run from 8% to 1%. Of course one could optimize further but I suggest to do the quick wins first with little risk of code regression.Performance gains are mainly in formatter rules but also in relatively expensive
UseSupportsShouldProcessrule.Also remove unused method. Technically this is a breaking change due to them being publicly exposed but I don't think people use them, the only usage that I can imagine is in custom rules. I did a global GitHub search and it confirmed that no one is probably using those APIs.
This class is quite disgusting overall, littered with TODOs and private/public methods spread across the file. Idea is to keep changes minimal and safe.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.