Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Newtonsoft json to 12.0.1 due to PowerShell 6.1 going out of support #1336
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedSep 12, 2019
PR Summary
This implicitly ups the minimum requirement for PS Core to
6.2.0(because PowerShell cannot load a newer version of Newtonsoft than the version that it ships with). This is OK because PS 6.1 will go out of support in a week anyway.I had to change the AppVeyor image to a newer one to get PS 6.2.0. If that AppVeyor had a newer patch of 6.2 then we could've even upgraded to Newtonsoft 12.0.2 (PowerShell 6.2.1 started shipping with this patch)
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.