Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevContainer support #1286

Merged
merged 6 commits into from Jan 28, 2020
Merged

Add DevContainer support #1286

merged 6 commits into from Jan 28, 2020

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Jul 10, 2019

PR Summary

This allows for developing in a container. Once .Net Core 3 releases its RTM version, I would like to upgrade the SDK, which will then contain PowerShell already. At the moment I have to bootstrap PowerShell myself, which is at least easier then using the PowerShell extension and bootstrapping the .Net SDK.
Dockerfile taken from .Net Core template of Docs page for VS-Code container development.

PR Checklist

@bergmeister bergmeister marked this pull request as ready for review Jul 10, 2019
@bergmeister bergmeister reopened this Sep 15, 2019
Christoph Bergmeister added 2 commits Jan 4, 2020
Copy link
Member

JamesWTruher left a comment

LGTM - please merge at your convenience

@bergmeister bergmeister merged commit fd885f9 into PowerShell:master Jan 28, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.