Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange logic for copying profiles into the 'install' directory #1197
Conversation
Multiple runs would result in incorrect layout of the compatibility profiles
|
Looks, OK, I am happy to close my alternative PR #1190 in favour of this. This brings back memories about PowerShell's iffy behaviour of |
cc75c62
into
PowerShell:development
2 checks passed
2 checks passed
license/cla
All CLA requirements met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JamesWTruher commentedMar 26, 2019
PR Summary
Multiple runs would result in an incorrect layout of the compatibility profiles
The problem did not exist in our CI/Release system as those are clean environments. This problem only exists if you run build multiple times.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.