Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPrevent .NET members with names differing only by case from crashing the compatibility profiler #1195
Conversation
|
Code change looks good to me but please write at least one simple test that would catch a regression |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rjmholt commentedMar 25, 2019
PR Summary
.NET allows type/member names that are case-insensitively equal on the same object (of course), but PowerShell can't differentiate these.
This changes the collector so that it builds a case-sensitive dictionary of types/members for JSON serialisation, rather than crashing when we hit this edge case (for the record, I hit Microsoft.Azure.Management.HDInsight.Job.Models.Profile having both
JobIDandJobIdas properties...).The query API still handles this without any problems: it just exposes the last property (it overwrites the previous one in the slot if there are duplicates). This is essentially consistent with PowerShell, which exposes the properties by reflection and also clobbers them in an undefined order.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.