gh-91362: reword pickle docs to account for nested classes#92429
Merged
JelleZijlstra merged 2 commits intopython:mainfrom May 21, 2022
Merged
gh-91362: reword pickle docs to account for nested classes#92429JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra merged 2 commits intopython:mainfrom
Conversation
Member
|
Maybe add something around line 522 where it says "This means that only the function name is pickled, along with the name of the module the function is defined in." That sentence is inaccurate for nested functions or methods. We can also link to https://docs.python.org/3/glossary.html#term-qualified-name. |
JelleZijlstra
approved these changes
May 19, 2022
Contributor
|
Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2022
…honGH-92429) Fixes pythonGH-91362 (cherry picked from commit f9d6c59) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
GH-93053 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2022
…honGH-92429) Fixes pythonGH-91362 (cherry picked from commit f9d6c59) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
GH-93054 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
May 21, 2022
miss-islington
added a commit
that referenced
this pull request
May 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the best wording.
Alternatives include:
#91362