Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pure-Python implementation of socket.socketpair() doesn't authenticate connected socket #122133

Open
sethmlarson opened this issue Jul 22, 2024 · 0 comments
Open

Pure-Python implementation of socket.socketpair() doesn't authenticate connected socket #122133

sethmlarson opened this issue Jul 22, 2024 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error type-security A security issue

Comments

@sethmlarson
Copy link
Contributor

sethmlarson commented Jul 22, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

socket.socketpair() has a fall-back implementation on platforms that don't support socket.AF_UNIX which uses AF_INET[6] sockets bound to localhost. This connection is expected to come from the same process.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, Windows

Linked PRs
@sethmlarson sethmlarson added type-bug An unexpected behavior, bug, or error type-security A security issue labels Jul 22, 2024
@bedevere-app bedevere-app bot mentioned this issue Jul 22, 2024
Merged
gpshead added a commit that referenced this issue Jul 29, 2024
@sethmlarson @gpshead
gh-122133: Authenticate socket connection for socket.socketpair() f…
78df104 
…allback (GH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2024
@sethmlarson @gpshead @miss-islington
pythongh-122133: Authenticate socket connection for `socket.socketpai…
4651665 
…r()` fallback (pythonGH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2024
@sethmlarson @gpshead @miss-islington
pythongh-122133: Authenticate socket connection for `socket.socketpai…
3a27581 
…r()` fallback (pythonGH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 29, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2024
@sethmlarson @gpshead @miss-islington
pythongh-122133: Authenticate socket connection for `socket.socketpai…
32ef8ea 
…r()` fallback (pythonGH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 29, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2024
@sethmlarson @gpshead @miss-islington
pythongh-122133: Authenticate socket connection for `socket.socketpai…
c590759 
…r()` fallback (pythonGH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
This was referenced Jul 29, 2024
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2024
@sethmlarson @gpshead @miss-islington
pythongh-122133: Authenticate socket connection for `socket.socketpai…
9f83e2b 
…r()` fallback (pythonGH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 29, 2024
@sethmlarson @gpshead @miss-islington
pythongh-122133: Authenticate socket connection for `socket.socketpai…
7be6ba7 
…r()` fallback (pythonGH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
This was referenced Jul 29, 2024
Merged
Merged
gpshead added a commit that referenced this issue Jul 29, 2024
@miss-islington @sethmlarson @gpshead
[3.12] gh-122133: Authenticate socket connection for `socket.socketpa…
220e31a 
…ir()` fallback (GH-122134) (GH-122425)

Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this issue Jul 30, 2024
@miss-islington @sethmlarson @gpshead
[3.13] gh-122133: Authenticate socket connection for `socket.socketpa…
b252317 
…ir()` fallback (GH-122134) (GH-122424)

Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this issue Jul 30, 2024
@miss-islington @sethmlarson @gpshead
[3.11] gh-122133: Authenticate socket connection for `socket.socketpa…
5f90aba 
…ir()` fallback (GH-122134) (#122426)

Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this issue Jul 30, 2024
@miss-islington @sethmlarson @gpshead
[3.10] gh-122133: Authenticate socket connection for `socket.socketpa…
0b65c8b 
…ir()` fallback (GH-122134) (#122427)

Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this issue Jul 30, 2024
@miss-islington @sethmlarson @gpshead
[3.9] gh-122133: Authenticate socket connection for `socket.socketpai…
06fa244 
…r()` fallback (GH-122134) (#122428)

Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv added a commit that referenced this issue Jul 30, 2024
@miss-islington @sethmlarson
@gpshead @ambv
[3.8] gh-122133: Authenticate socket connection for `socket.socketpai…
2621a8a 
…r()` fallback (GH-122134) (GH-122429)

Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app bedevere-app bot mentioned this issue Jul 31, 2024
Merged
Yhg1s pushed a commit that referenced this issue Jul 31, 2024
@freakboy3742 @gpshead
gh-122133: Rework pure Python socketpair tests to avoid use of import…
f071f01 
…lib.reload. (#122493)


Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 31, 2024
@freakboy3742 @gpshead @miss-islington
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
3c2d9c6 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01b7b7e19d7d6b3a4b0ec62f820ecb14660)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 31, 2024
@freakboy3742 @gpshead @miss-islington
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
3f4f577 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01b7b7e19d7d6b3a4b0ec62f820ecb14660)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 31, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 31, 2024
@freakboy3742 @gpshead @miss-islington
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
c9e5b67 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01b7b7e19d7d6b3a4b0ec62f820ecb14660)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 31, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 31, 2024
@freakboy3742 @gpshead @miss-islington
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
0d54900 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01b7b7e19d7d6b3a4b0ec62f820ecb14660)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 31, 2024
Open
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 31, 2024
@freakboy3742 @gpshead @miss-islington
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
312495b 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 31, 2024
Open
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 31, 2024
@freakboy3742 @gpshead @miss-islington
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
6f9ff6b 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
This was referenced Jul 31, 2024
Open
Open
Yhg1s pushed a commit that referenced this issue Jul 31, 2024
@miss-islington @freakboy3742 @gpshead
[3.13] gh-122133: Rework pure Python socketpair tests to avoid use of…
c21a361 
… importlib.reload. (GH-122493) (#122504)

gh-122133: Rework pure Python socketpair tests to avoid use of importlib.reload. (GH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this issue Jul 31, 2024
@miss-islington @freakboy3742 @gpshead
[3.12] gh-122133: Rework pure Python socketpair tests to avoid use of…
5df322e 
… importlib.reload. (GH-122493) (GH-122505)

gh-122133: Rework pure Python socketpair tests to avoid use of importlib.reload. (GH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error type-security A security issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sethmlarson