Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pyrepl cache doesn't play well with history #121499

Closed
pablogsal opened this issue Jul 8, 2024 · 2 comments
Closed

The pyrepl cache doesn't play well with history #121499

pablogsal opened this issue Jul 8, 2024 · 2 comments
Labels
topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error

Comments

@pablogsal
Copy link
Member

pablogsal commented Jul 8, 2024 •
edited by bedevere-app bot
Loading

Type the following in the REPL:

>>> def foo():
...     x = 1
...     y = 2
...     z = 3
...
>>> def bar():
...     return 42
...

Now press up arrow 3 times to go to the foo function. The REPL shows:

>>> def bar():
...     x = 1
...     y = 2
...     z = 3

which is a weird mix between the two entries.

I have bisected this to 32a0fab

Linked PRs
@pablogsal pablogsal changed the title The pyrepl cache doesn't play well with historu The pyrepl cache doesn't play well with history Jul 8, 2024
@pablogsal
Copy link
Member Author

CC @godlygeek

@Eclips4 Eclips4 added topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error labels Jul 8, 2024
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 9, 2024
@pablogsal
pythongh-121499: Fix multi-line history rendering in the REPL
ea0c0cb
@bedevere-app bedevere-app bot mentioned this issue Jul 9, 2024
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 9, 2024
@pablogsal
pythongh-121499: Fix multi-line history rendering in the REPL
b9afca1
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 9, 2024
@pablogsal
pythongh-121499: Fix multi-line history rendering in the REPL
f589b69 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@picnixz
Copy link
Contributor

picnixz commented Jul 9, 2024

Could it be related to #120460?

pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 13, 2024
@pablogsal
pythongh-121499: Fix multi-line history rendering in the REPL
9a1a74b 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 13, 2024
@pablogsal
pythongh-121499: Fix multi-line history rendering in the REPL
a46f16f 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 13, 2024
@pablogsal
pythongh-121499: Fix multi-line history rendering in the REPL
39ae20c 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
ambv pushed a commit that referenced this issue Jul 13, 2024
@pablogsal
gh-121499: Fix multi-line history rendering in the REPL (#121531)
4b9e10d 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 13, 2024
@pablogsal @miss-islington
pythongh-121499: Fix multi-line history rendering in the REPL (python…
273a378 
…GH-121531)

(cherry picked from commit 4b9e10d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jul 13, 2024
Merged
pablogsal added a commit that referenced this issue Jul 13, 2024
@miss-islington @pablogsal
[3.13] gh-121499: Fix multi-line history rendering in the REPL (GH-12…
de51ee0 
…1531) (#121679)

gh-121499: Fix multi-line history rendering in the REPL (GH-121531)
(cherry picked from commit 4b9e10d)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@pablogsal @estyxx
pythongh-121499: Fix multi-line history rendering in the REPL (python…
9ad749a 
…#121531)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@picnixz @pablogsal @Eclips4