bpo-40721: add note about enum member name case#22231
Merged
ethanfurman merged 2 commits intopython:masterfrom Sep 14, 2020
Merged
bpo-40721: add note about enum member name case#22231ethanfurman merged 2 commits intopython:masterfrom
ethanfurman merged 2 commits intopython:masterfrom
Conversation
Contributor
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 14, 2020
* UPPER_CASE preferred as enum members are constants (cherry picked from commit 542e1df) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
|
GH-22247 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 14, 2020
* UPPER_CASE preferred as enum members are constants (cherry picked from commit 542e1df) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
|
GH-22248 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 14, 2020
miss-islington
added a commit
that referenced
this pull request
Sep 14, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
* UPPER_CASE preferred as enum members are constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which is that UPPER_CASE is preferred as enums are constants.
https://bugs.python.org/issue40721