Skip to content

Corrected Chocolatey Install Command#7063

Merged
cPu1 merged 2 commits intoeksctl-io:mainfrom
Nyami:patch-1
Sep 12, 2023
Merged

Corrected Chocolatey Install Command#7063
cPu1 merged 2 commits intoeksctl-io:mainfrom
Nyami:patch-1

Conversation

@Nyami
Copy link
Copy Markdown
Contributor

@Nyami Nyami commented Sep 12, 2023 •
edited by cPu1
Loading

Description

Corrected the installation command for chocolatey ensuring chocolatey can copy/paste command

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Nyami
Corrected Chocolatey Install Command
5a3b1de 
Corrected the installation command for chocolatey ensuring chocolatey can copy/paste command
github-actions[bot]
github-actions Bot reviewed Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Nyami 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

cPu1
cPu1 reviewed Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Thanks, @Nyami. The README also needs to be updated.

@Nyami
Update README.md
4a4e9d5 
Corrected chocolatey command
@Nyami
Copy link
Copy Markdown
Contributor Author

Nyami commented Sep 12, 2023

The README also needs to be updated.

That should be the readme updated now.

@cPu1 cPu1 added kind/docs User documentation area/docs labels Sep 12, 2023
@cPu1 cPu1 merged commit edb7fb2 into eksctl-io:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@cPu1 cPu1 cPu1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/docs User documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nyami @cPu1