Fix hosted tool cache usage on windows #411

galargh · 2023-08-12T22:04:14Z

Description:
This change ensures that we symlink not only the tool directory but also the completion marker when adding go to the hosted tool cache on Windows.

Related issue:
Not raised, but without this change it is impossible to run the action twice with the same go-version input on Windows because the second run fails with errors related to files already existing.

Testing:

🔴 Example test run without the fix: https://github.com/galargh/setup-go/actions/runs/5843165063/job/15845040764
🟢 Example test run with the fix: https://github.com/galargh/setup-go/actions/runs/5843616834/job/15845918944

Check list:

Mark if documentation changes are required. NOT REQUIRED
Mark if tests were added or updated to cover the changes.

dsame

I confirm changing "junction" to "dir" does not solve the problem and this fix must be applied

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-go](https://togithub.com/actions/setup-go) | action | major | `v4.1.0` -> `v5.0.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/setup-go (actions/setup-go)</summary> ### [`v5.0.0`](https://togithub.com/actions/setup-go/releases/tag/v5.0.0) [Compare Source](https://togithub.com/actions/setup-go/compare/v4.1.0...v5.0.0) #### What's Changed In scope of this release, we change Nodejs runtime from node16 to node20 ([actions/setup-go#421). Moreover, we update some dependencies to the latest versions ([actions/setup-go#445). Besides, this release contains such changes as: - Fix hosted tool cache usage on windows by [@galargh](https://togithub.com/galargh) in [actions/setup-go#411 - Improve documentation regarding dependencies caching by [@artemgavrilov](https://togithub.com/artemgavrilov) in [actions/setup-go#417 #### New Contributors - [@galargh](https://togithub.com/galargh) made their first contribution in [actions/setup-go#411 - [@artemgavrilov](https://togithub.com/artemgavrilov) made their first contribution in [actions/setup-go#417 - [@chenrui333](https://togithub.com/chenrui333) made their first contribution in [actions/setup-go#421 **Full Changelog**: actions/setup-go@v4...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♄1�7 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/zarf).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Bumps actions/setup-go from 4 to 5. Release notes Sourced from actions/setup-go's releases. v5.0.0 What's Changed In scope of this release, we change Nodejs runtime from node16 to node20 (actions/setup-go#421). Moreover, we update some dependencies to the latest versions (actions/setup-go#445). Besides, this release contains such changes as: Fix hosted tool cache usage on windows by @galargh in actions/setup-go#411 Improve documentation regarding dependencies caching by @artemgavrilov in actions/setup-go#417 New Contributors @galargh made their first contribution in actions/setup-go#411 @artemgavrilov made their first contribution in actions/setup-go#417 @chenrui333 made their first contribution in actions/setup-go#421 Full Changelog: actions/setup-go@v4...v5.0.0 v4.1.0 What's Changed In scope of this release, slow installation on Windows was fixed by @dsame in actions/setup-go#393 and OS version was added to primaryKey for Ubuntu runners to avoid conflicts (actions/setup-go#383) This release also includes the following changes: Remove implicit dependencies by @nikolai-laevskii in actions/setup-go#378 Update action.yml by @mkelly in actions/setup-go#379 Added a description that go-version should be specified as a string type by @n3xem in actions/setup-go#367 Add note about YAML parsing versions by @dmitry-shibanov in actions/setup-go#382 Automatic update of configuration files from 05/23/2023 by @github-actions in actions/setup-go#377 Bump tough-cookie and @azure/ms-rest-js by @dependabot in actions/setup-go#392 Bump word-wrap from 1.2.3 to 1.2.4 by @dependabot in actions/setup-go#397 Bump semver from 6.3.0 to 6.3.1 by @dependabot in actions/setup-go#396 New Contributors @mkelly made their first contribution in actions/setup-go#379 @n3xem made their first contribution in actions/setup-go#367 Full Changelog: actions/setup-go@v4...v4.1.0 v4.0.1 What's Changed Update documentation for v4 by @dsame in actions/setup-go#354 Fix glob bug in the package.json scripts section by @IvanZosimov in actions/setup-go#359 Bump xml2js dependency by @dmitry-shibanov in actions/setup-go#370 Bump @actions/cache dependency to v3.2.1 by @nikolai-laevskii in actions/setup-go#374 New Contributors @nikolai-laevskii made their first contribution in actions/setup-go#374 Full Changelog: actions/setup-go@v4...v4.0.1

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-go](https://togithub.com/actions/setup-go) | action | major | `v4.1.0` -> `v5.0.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/setup-go (actions/setup-go)</summary> ### [`v5.0.0`](https://togithub.com/actions/setup-go/releases/tag/v5.0.0) [Compare Source](https://togithub.com/actions/setup-go/compare/v4.1.0...v5.0.0) ##### What's Changed In scope of this release, we change Nodejs runtime from node16 to node20 ([actions/setup-go#421). Moreover, we update some dependencies to the latest versions ([actions/setup-go#445). Besides, this release contains such changes as: - Fix hosted tool cache usage on windows by [@galargh](https://togithub.com/galargh) in [actions/setup-go#411 - Improve documentation regarding dependencies caching by [@artemgavrilov](https://togithub.com/artemgavrilov) in [actions/setup-go#417 ##### New Contributors - [@galargh](https://togithub.com/galargh) made their first contribution in [actions/setup-go#411 - [@artemgavrilov](https://togithub.com/artemgavrilov) made their first contribution in [actions/setup-go#417 - [@chenrui333](https://togithub.com/chenrui333) made their first contribution in [actions/setup-go#421 **Full Changelog**: actions/setup-go@v4...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♄1�7 **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/parca-dev/parca-agent).

Bumps actions/setup-go from 4 to 5. Release notes Sourced from actions/setup-go's releases. v5.0.0 What's Changed In scope of this release, we change Nodejs runtime from node16 to node20 (actions/setup-go#421). Moreover, we update some dependencies to the latest versions (actions/setup-go#445). Besides, this release contains such changes as: Fix hosted tool cache usage on windows by @galargh in actions/setup-go#411 Improve documentation regarding dependencies caching by @artemgavrilov in actions/setup-go#417 New Contributors @galargh made their first contribution in actions/setup-go#411 @artemgavrilov made their first contribution in actions/setup-go#417 @chenrui333 made their first contribution in actions/setup-go#421 Full Changelog: actions/setup-go@v4...v5.0.0 v4.1.0 What's Changed In scope of this release, slow installation on Windows was fixed by @dsame in actions/setup-go#393 and OS version was added to primaryKey for Ubuntu runners to avoid conflicts (actions/setup-go#383) This release also includes the following changes: Remove implicit dependencies by @nikolai-laevskii in actions/setup-go#378 Update action.yml by @mkelly in actions/setup-go#379 Added a description that go-version should be specified as a string type by @n3xem in actions/setup-go#367 Add note about YAML parsing versions by @dmitry-shibanov in actions/setup-go#382 Automatic update of configuration files from 05/23/2023 by @github-actions in actions/setup-go#377 Bump tough-cookie and @azure/ms-rest-js by @dependabot in actions/setup-go#392 Bump word-wrap from 1.2.3 to 1.2.4 by @dependabot in actions/setup-go#397 Bump semver from 6.3.0 to 6.3.1 by @dependabot in actions/setup-go#396 New Contributors @mkelly made their first contribution in actions/setup-go#379 @n3xem made their first contribution in actions/setup-go#367 Full Changelog: actions/setup-go@v4...v4.1.0 v4.0.1 What's Changed Update documentation for v4 by @dsame in actions/setup-go#354 Fix glob bug in the package.json scripts section by @IvanZosimov in actions/setup-go#359 Bump xml2js dependency by @dmitry-shibanov in actions/setup-go#370 Bump @actions/cache dependency to v3.2.1 by @nikolai-laevskii in actions/setup-go#374 New Contributors @nikolai-laevskii made their first contribution in actions/setup-go#374 Full Changelog: actions/setup-go@v4...v4.0.1

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/download-artifact](https://togithub.com/actions/download-artifact) | action | major | `v3` -> `v4` | | [actions/setup-go](https://togithub.com/actions/setup-go) | action | major | `v4.1.0` -> `v5.0.0` | | [actions/setup-go](https://togithub.com/actions/setup-go) | action | major | `v4` -> `v5` | | [actions/upload-artifact](https://togithub.com/actions/upload-artifact) | action | major | `v3.1.3` -> `v4.0.0` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | major | `v2.23.0` -> `v3.23.0` | --- ### Release Notes <details> <summary>actions/download-artifact (actions/download-artifact)</summary> ### [`v4`](https://togithub.com/actions/download-artifact/compare/v3...v4) [Compare Source](https://togithub.com/actions/download-artifact/compare/v3...v4) </details> <details> <summary>actions/setup-go (actions/setup-go)</summary> ### [`v5.0.0`](https://togithub.com/actions/setup-go/releases/tag/v5.0.0) [Compare Source](https://togithub.com/actions/setup-go/compare/v4.1.0...v5.0.0) ##### What's Changed In scope of this release, we change Nodejs runtime from node16 to node20 ([actions/setup-go#421). Moreover, we update some dependencies to the latest versions ([actions/setup-go#445). Besides, this release contains such changes as: - Fix hosted tool cache usage on windows by [@galargh](https://togithub.com/galargh) in [actions/setup-go#411 - Improve documentation regarding dependencies caching by [@artemgavrilov](https://togithub.com/artemgavrilov) in [actions/setup-go#417 ##### New Contributors - [@galargh](https://togithub.com/galargh) made their first contribution in [actions/setup-go#411 - [@artemgavrilov](https://togithub.com/artemgavrilov) made their first contribution in [actions/setup-go#417 - [@chenrui333](https://togithub.com/chenrui333) made their first contribution in [actions/setup-go#421 **Full Changelog**: actions/setup-go@v4...v5.0.0 </details> <details> <summary>actions/upload-artifact (actions/upload-artifact)</summary> ### [`v4.0.0`](https://togithub.com/actions/upload-artifact/releases/tag/v4.0.0) [Compare Source](https://togithub.com/actions/upload-artifact/compare/v3.1.3...v4.0.0) #### What's Changed The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements. For more information, see the [@actions/artifact](https://togithub.com/actions/toolkit/tree/main/packages/artifact) documentation. #### New Contributors - [@vmjoseph](https://togithub.com/vmjoseph) made their first contribution in [actions/upload-artifact#464 **Full Changelog**: actions/upload-artifact@v3...v4.0.0 </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.23.0`](https://togithub.com/github/codeql-action/compare/v3.22.12...v3.23.0) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.22.12...v3.23.0) ### [`v3.22.12`](https://togithub.com/github/codeql-action/compare/v3.22.11...v3.22.12) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.22.11...v3.22.12) ### [`v3.22.11`](https://togithub.com/github/codeql-action/compare/v2.22.11...v3.22.11) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.23.0...v3.22.11) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♄1�7 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner).

galargh added 3 commits August 12, 2023 21:56

ci: add hostedtoolcache validation on windows

aabcd82

fix: sync .complete marker when caching tools on windows

89a192a

chore: format

48ac8fd

galargh requested a review from a team as a code owner August 12, 2023 22:04

dmitry-shibanov approved these changes Aug 14, 2023

View reviewed changes

dsame approved these changes Aug 14, 2023

View reviewed changes

dsame self-assigned this Aug 14, 2023

marko-zivic-93 approved these changes Aug 16, 2023

View reviewed changes

marko-zivic-93 merged commit d085b4f into actions:main Aug 24, 2023
71 checks passed

galargh mentioned this pull request Aug 28, 2023

Cache go modules and build cache protocol/.github#467

Closed

This was referenced Dec 7, 2023

Bump actions/setup-go from 4 to 5 tonglil/buflogr#12

Merged

Bump actions/setup-go from 4 to 5 tonglil/opentelemetry-go-datadog-propagator#41

Merged

Bump actions/setup-go from 4 to 5 tonglil/gokitlogr#11

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix hosted tool cache usage on windows #411

Fix hosted tool cache usage on windows #411

galargh commented Aug 12, 2023

dsame left a comment

Fix hosted tool cache usage on windows #411

Fix hosted tool cache usage on windows #411

Conversation

galargh commented Aug 12, 2023

dsame left a comment

Choose a reason for hiding this comment