Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-90699: Remove _Py_IDENTIFIER usage from _json module #98956

Merged
merged 6 commits into from Nov 2, 2022
Merged

GH-90699: Remove _Py_IDENTIFIER usage from _json module #98956

merged 6 commits into from Nov 2, 2022
+46 −29

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 1, 2022 •
edited by miss-islington

Automerge-Triggered-By: GH:ericsnowcurrently

@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2022
Open
Fidget-Spinner
Fidget-Spinner reviewed Nov 1, 2022
View changes
Modules/_json.c Outdated Show resolved Hide resolved
ericsnowcurrently
ericsnowcurrently approved these changes Nov 2, 2022
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM

@ericsnowcurrently ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 2, 2022
@miss-islington miss-islington merged commit 780757a into python:main Nov 2, 2022
13 checks passed
@kumaraditya303 kumaraditya303 deleted the json branch Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kumaraditya303 @ericsnowcurrently @Fidget-Spinner @bedevere-bot @miss-islington