Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos detection to New-CommandDataFile #947

Merged
merged 2 commits into from Mar 27, 2018
Merged

Add macos detection to New-CommandDataFile #947

merged 2 commits into from Mar 27, 2018

Conversation

@GavinEke
Copy link
Contributor

GavinEke commented Mar 26, 2018 •
edited

PR Summary

Add MacOS Detection as $os in PSCore v6.0.0-beta.7 and higher are getting incorrectly set as windows in the Get-CmdletDataFileName function

More details: https://github.com/PowerShell/PowerShell/blob/master/docs/BREAKINGCHANGES.md#rename-isosx-to-ismacos-4700

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • [NA] User facing documentation needed
  • Change is not breaking
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
Gavin Eke and others added 2 commits Mar 26, 2018
Gavin Eke
Add macos detection to New-CommandDataFile
Loading status checks…
5ed29a4
@bergmeister
Remove old 'elseif ($IsOSX)' since there is no need to support old Be…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a37f9d5 
…ta versions.
@bergmeister
bergmeister approved these changes Mar 26, 2018
View changes
Copy link
Collaborator

bergmeister left a comment

Thanks for contributing. The change makes sense to me. But I do not see the need to support old Beta versions of PowerShell Core, therefore I removed the elseif ($IsOSX) block. Otherwise looks good to me. I tend to keep PRs open for at least 24h for visibility to others and will merge it then if there are no objections from others.
@bergmeister bergmeister self-assigned this Mar 26, 2018
@bergmeister bergmeister added this to the 1.17 milestone Mar 26, 2018
@bergmeister bergmeister merged commit 7fd10cd into PowerShell:development Mar 27, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
@bergmeister bergmeister mentioned this pull request Apr 3, 2018
Closed
6 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister

Assignees

@bergmeister bergmeister

Labels
None yet
Projects
None yet
Milestone
1.17
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@GavinEke @bergmeister
You can’t perform that action at this time.