Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix ps3 syntax check #1395
Merged
Fix ps3 syntax check #1395
Conversation
|
Apart from the question around why severity changed, looks ok but the build is not green, therefore once the build is green, I think it can go in |
100% agreed, will work on that this week hopefully. |
a415198
into
PowerShell:master
8 checks passed
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rjmholt commentedJan 16, 2020
PR Summary
Fixes #1384.
UseCompatibleSyntax used to erroneously advise that dynamic member expressions don't work in PS 3. Now it does not.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.