Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTake module version into account for -SaveDscDependency switch #1094
Conversation
|
lgtm |
bergmeister
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
…Shell#1094) * Take module version into account for SaveDscDependency and remove old dead code * fix tests and add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedNov 5, 2018
•
edited
PR Summary
Fixes #1079 and removes some old dead code.
This is a minimum viable implementation so that we cater for the version as well. It can parse now e.g.
Import-DscResource -ModuleName MyModuleName -ModuleVersion 1.2.3.4, before it could not handle theModuleVersionparameter.It does not cover cases when not using named parameters or the parameter sets where multiple modules are being used or the (rather old) form of the module specification syntax (e.g.
–ModuleName @{ModuleName="xPSDesiredStateConfiguration";ModuleVersion="8.3.0.0"}PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.