Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111178: Avoid calling functions from incompatible pointer types in memoryobject.c #112863

Merged
merged 19 commits into from Dec 11, 2023
Merged

gh-111178: Avoid calling functions from incompatible pointer types in memoryobject.c #112863

merged 19 commits into from Dec 11, 2023

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Dec 8, 2023 •
edited by bedevere-app bot

@chrstphrchvz
Make memory_clear() compatible with inquiry
239cc5d
@chrstphrchvz
Make memory_traverse() compatible with traverseproc
3c376a5
@chrstphrchvz
Make memory_dealloc() compatible with destructor
4b194a8
@chrstphrchvz
Make memory_repr() compatible with reprfunc
52c4537
@chrstphrchvz
Make memory_hash() compatible with hashfunc
92f48e6
@chrstphrchvz
Make memoryiter_next() compatible with iternextfunc
60b15fb
@chrstphrchvz
Make memoryiter_traverse() compatible with traverseproc
b0a78b0
@chrstphrchvz
Make memoryiter_dealloc() compatible with destructor
1662664
@chrstphrchvz
Make several functions compatible with getter
384357a
@chrstphrchvz
Make a few functions compatible with getter
09c83f8
@chrstphrchvz
Make memory_item() compatible with ssizeargfunc
bafeb88
@chrstphrchvz
Make memory_subscript() compatible with binaryfunc
d4f704a
@chrstphrchvz
Make memory_length() compatible with lenfunc
deaa83d
@chrstphrchvz
Make memory_ass_sub() compatible with objobjargproc
b7fd5e0
@chrstphrchvz
Make memory_releasebuf() compatible with releasebufferproc
538ad83
@chrstphrchvz
Make memory_getbuf() compatible with getbufferproc
df53cd0
@chrstphrchvz
Make mbuf_clear() compatible with inquiry
aeb1630
@chrstphrchvz
Make mbuf_traverse() compatible with traverseproc
ae90d75
@chrstphrchvz
Make mbuf_dealloc() compatible with destructor
0f26620
@bedevere-app bedevere-app bot mentioned this pull request Dec 8, 2023
Open
encukou
encukou approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for helping to avoid UB.

@encukou encukou merged commit f4fe65e into python:main Dec 11, 2023
34 checks passed
arhadthedev added a commit to arhadthedev/cpython that referenced this pull request Dec 11, 2023
@arhadthedev
index on main: f4fe65e pythongh-111178: Avoid calling functions from …
364cf92 
…incompatible pointer types in memoryobject.c (pythonGH-112863)
arhadthedev added a commit to arhadthedev/cpython that referenced this pull request Dec 11, 2023
@arhadthedev
WIP on main: f4fe65e pythongh-111178: Avoid calling functions from in…
1a351a5 
…compatible pointer types in memoryobject.c (pythonGH-112863)
@chrstphrchvz chrstphrchvz deleted the patch-111178-memoryobject branch December 12, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrstphrchvz @encukou