Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) #184

Merged
merged 16 commits into from Feb 5, 2018

Conversation

@mrwogu
Copy link
Contributor

@mrwogu mrwogu commented Dec 13, 2017

No description provided.

@mrwogu mrwogu force-pushed the mrwogu:php-7.2 branch from 985cf53 to ea4b8af Dec 13, 2017
@mrwogu
Copy link
Contributor Author

@mrwogu mrwogu commented Dec 13, 2017

Build passed successfully for:

  • 7.0
  • 7.1

but i don't know why for 7.2 i've got php-cs-fixer sugesstions on files which i didn't touch.
Maybe you have to think about php-cs-fixer update (current version is: 1.11.8)

@haphan
Copy link
Collaborator

@haphan haphan commented Dec 13, 2017

I think we definitely should update some out-of-date dependencies like php-cs-fixer. Don't mind if you can update php-cs-fixer in this PR as well.

Support for php 7.2 will result in a new major version since there are some BC breaks.

@haphan
Copy link
Collaborator

@haphan haphan commented Dec 13, 2017

@mrwogu BaseObject sounds misleading to me, at least from a developers perspective, BaseObject often use in the context of an abstract class.

What about using StorageObject instead?

@mrwogu mrwogu force-pushed the mrwogu:php-7.2 branch from ea4b8af to 4b12e4b Dec 16, 2017
@mrwogu
Copy link
Contributor Author

@mrwogu mrwogu commented Dec 16, 2017

Ok, i've renamed from Object to StorageObject.
php-cs-fixer has been updated and works fine now.

Unfortunately, PHPUnit is also outdated and I had to update it to a new version.
Could you check these errors?

@mrwogu mrwogu changed the title PHP 7.2 Compatibility PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) Jan 6, 2018
@mrwogu mrwogu force-pushed the mrwogu:php-7.2 branch from 9a809c5 to 61e3826 Jan 7, 2018
@nicolasmure nicolasmure mentioned this pull request Jan 14, 2018
@mrwogu mrwogu force-pushed the mrwogu:php-7.2 branch 3 times, most recently from d6ac9a5 to 0a44efa Jan 27, 2018
@mrwogu
Copy link
Contributor Author

@mrwogu mrwogu commented Jan 28, 2018

@haphan could you merge this into php-opencloud:php-7.2?
I also rebased my branch with master.

@haphan
Copy link
Collaborator

@haphan haphan commented Feb 3, 2018

Great works @mrwogu but I think commits got messed up during rebase.

Can you try to rebase it again?

@mrwogu mrwogu force-pushed the mrwogu:php-7.2 branch from 0a44efa to f837c8e Feb 3, 2018
@mrwogu
Copy link
Contributor Author

@mrwogu mrwogu commented Feb 3, 2018

@haphan done

@haphan haphan force-pushed the php-opencloud:php-7.2 branch from a6e9036 to cdfcd5e Feb 4, 2018
haphan added 4 commits Feb 5, 2018
@haphan haphan merged commit 2346777 into php-opencloud:php-7.2 Feb 5, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@haphan
Copy link
Collaborator

@haphan haphan commented Feb 5, 2018

@mrwogu Awesome works! 🎸

I've made only minor improvements to the README and php-cs-fixer.

Branch 2.0 will now contain version 2.x and master for 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.