New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GO - Add sink for libxml2 in go/xml/xpath-injection via XPath.qll #15181
Open
felickz
wants to merge
10
commits into
github:main
Choose a base branch
from
felickz:go-xxe-libxml2
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+264
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sample test (test not compiling) - Stubs not generating
felickz
commented
Dec 20, 2023
felickz
commented
Dec 20, 2023
owen-mc
reviewed
Dec 20, 2023
(it will automatically make stubs for all the methods on that type) Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
- still failing with ./tst.go:195:25: undefined: parser.XMLParseNoEnt
felickz
commented
Dec 21, 2023
felickz
commented
Dec 21, 2023
| | tst.go:152:14:152:35 | call to Get | tst.go:164:31:164:126 | ...+... | | ||
| | tst.go:152:14:152:35 | call to Get | tst.go:173:21:173:116 | ...+... | | ||
| | tst.go:152:14:152:35 | call to Get | tst.go:182:27:182:122 | ...+... | | ||
| | tst.go:193:14:193:19 | selection of Form | tst.go:193:14:193:35 | call to Get | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
felickz
commented
Dec 21, 2023
| | tst.go:164:31:164:126 | ...+... | semmle.label | ...+... | | ||
| | tst.go:173:21:173:116 | ...+... | semmle.label | ...+... | | ||
| | tst.go:182:27:182:122 | ...+... | semmle.label | ...+... | | ||
| | tst.go:193:14:193:19 | selection of Form | semmle.label | selection of Form | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
owen-mc
previously approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for XXE sinks via the libxml2 package for Parse/ParseString/ParseReader
Changes
LestratGoLibxml2XPathExpressionStringto theXPathmodule in thego/ql/lib/semmle/go/frameworks/XPath.qllfile.ParserAPI functions of thelestrrat-go/libxml2package.Parse%naming pattern within thegithub.com/lestrrat-go/libxml2/parser.Parserpackage and assigns the first argument of the function call as an instance of this class.Testing:
go/ql/testdepstubber -vendor github.com/lestrrat-go/libxml2/parser Parser New,XMLParseNoEntgo build ./...