Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Model simple pattern matching as value steps instead of taint steps #15103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ruby: Model simple pattern matching as value steps instead of taint steps #15103

wants to merge 1 commit into from
+44 −11

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Dec 14, 2023 •
edited

Until we have proper data flow for pattern matching (possibly using desugaring and flow summaries), this PR changes simple pattern matches such as

case value
  in Foo => x then ...
  in y => then ...
end

from being taint steps to value steps.

@github-actions github-actions bot added the Ruby label Dec 14, 2023
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Dec 15, 2023
@hvitved hvitved marked this pull request as ready for review December 15, 2023 08:09
@hvitved hvitved requested a review from a team as a code owner December 15, 2023 08:09
@hvitved hvitved requested a review from aibaars December 15, 2023 12:21
@hmac
Copy link
Contributor

hmac commented Dec 15, 2023

(didn't notice the request for Arthur, sorry! Still, this seems a reasonable change to me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmac hmac hmac approved these changes

@aibaars aibaars Awaiting requested review from aibaars

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hvitved @hmac