Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99139: Improve NameError error suggestion for instances #99140

Merged
merged 7 commits into from Nov 6, 2022
Merged

gh-99139: Improve NameError error suggestion for instances #99140

merged 7 commits into from Nov 6, 2022
+92 −0

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 5, 2022 •
edited by bedevere-bot

@pablogsal pablogsal requested a review from iritkatriel as a code owner Nov 5, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 5, 2022
Closed
@pablogsal pablogsal requested review from isidentical and ammaraskar Nov 5, 2022
ammaraskar
ammaraskar approved these changes Nov 5, 2022
View changes
Copy link
Member

@ammaraskar ammaraskar left a comment

Looks great :)

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Python/suggestions.c Outdated Show resolved Hide resolved
@pablogsal @ammaraskar
Update Doc/whatsnew/3.12.rst
b1546e5 
Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
isidentical
isidentical reviewed Nov 5, 2022
View changes
Python/suggestions.c Outdated Show resolved Hide resolved
isidentical
isidentical approved these changes Nov 5, 2022
View changes
Copy link
Sponsor Member

@isidentical isidentical left a comment

Looks really helpful, thanks a lot @pablogsal!

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 5, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 5, 2022

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit b1546e5 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 5, 2022
pablogsal and others added 3 commits Nov 6, 2022
@pablogsal @ammaraskar
Update Python/suggestions.c
8a244b9 
Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
@pablogsal @isidentical
Update Python/suggestions.c
d8933dd 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@pablogsal @isidentical
Update Python/suggestions.c
4925719 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 6, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 6, 2022

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4925719 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 6, 2022
kumaraditya303
kumaraditya303 requested changes Nov 6, 2022
View changes
Python/suggestions.c Outdated Show resolved Hide resolved
kumaraditya303
kumaraditya303 reviewed Nov 6, 2022
View changes
Python/suggestions.c Outdated Show resolved Hide resolved
@pablogsal @kumaraditya303
Update Python/suggestions.c
ab2874a 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303
kumaraditya303 reviewed Nov 6, 2022
View changes
Python/suggestions.c Outdated Show resolved Hide resolved
@pablogsal pablogsal merged commit 99e2e60 into python:main Nov 6, 2022
14 of 15 checks passed
@pablogsal pablogsal deleted the better_attr branch Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303

@ammaraskar ammaraskar

@isidentical isidentical

@iritkatriel iritkatriel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @bedevere-bot @ammaraskar @isidentical @kumaraditya303