KAFKA-15470: Allow creating connectors in a stopped state #14704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9816762 to
9dbb418
Compare
C0urante
reviewed
Nov 7, 2023
Contributor
C0urante
left a comment
There was a problem hiding this comment.
Thanks Yash, this is looking great. I've made it through all of the functional changes; planning to review tests later this week.
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java
Outdated
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java
Outdated
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Herder.java
Show resolved
Hide resolved
...untime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java
Outdated
Show resolved
Hide resolved
connect/runtime/src/test/java/org/apache/kafka/connect/cli/ConnectStandaloneTest.java
Show resolved
Hide resolved
…new CreateConnectorRequest::initialTargetState method; minor docs updates; additional tests; other minor refactors
yashmayya
commented
Nov 8, 2023
Contributor
Author
yashmayya
left a comment
There was a problem hiding this comment.
Thanks for the review Chris, thorough as always!
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Herder.java
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks Chris! Test failures appear unrelated, merging to |
Merged
3 tasks
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Jan 2, 2024
Reviewers: Chris Egerton <chrise@aiven.io>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
Reviewers: Chris Egerton <chrise@aiven.io>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
Reviewers: Chris Egerton <chrise@aiven.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
Reviewers: Chris Egerton <chrise@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial_statein thePOST /connectorsendpointCommitter Checklist (excluded from commit message)