Ensure cli using latest version from the supported_cli_versions.json #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shati-patel
reviewed
Jan 20, 2023
There was a problem hiding this comment.
The main workflow also need an update:
vscode-codeql/.github/workflows/main.yml
Line 194 in b0168aa
Otherwise, LGTM with just some minor comments! (I tried running the CLI tests locally too, and all good
| // CLI version to test. Hard code the latest as default. And be sure | ||
| // to update the env if it is not otherwise set. |
There was a problem hiding this comment.
Minor suggestion to make the comment clearer. Something like this?
Suggested change
| // CLI version to test. Hard code the latest as default. And be sure | |
| // to update the env if it is not otherwise set. | |
| // CLI version to test. Use the latest supported version by default. | |
| // And be sure to update the env if it is not otherwise set. |
| @@ -38,7 +39,7 @@ const _10MB = _1MB * 10; | |||
|
|
|||
| // CLI version to test. Hard code the latest as default. And be sure | |||
| // to update the env if it is not otherwise set. | |||
| const CLI_VERSION = process.env.CLI_VERSION || "v2.11.6"; | |||
| const CLI_VERSION = process.env.CLI_VERSION || data[0]; | |||
There was a problem hiding this comment.
Minor: we could make this variable name more descriptive
Suggested change
| const CLI_VERSION = process.env.CLI_VERSION || data[0]; | |
| const CLI_VERSION = process.env.CLI_VERSION || supportedCliVersions[0]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
closes this issue
The PR changes the bump-cli workflow to only edit the馃槃
supported_cli_versions.jsonfile and remove the need to editensureCli.tswhich used to include a hardcoded string of the latest version. Now however, it takes the latest version from thesupported_cli_versions.json(the first version in the array insupported_cli_versions.jsonis always going to be the latest version of the supported cli by design) removing the need to update theensureCli.tsfile