Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java/C++/RangeAnalysis: Move a couple of utility predicates to shared qlpack #14711

Merged
merged 2 commits into from Nov 8, 2023
Merged

Java/C++/RangeAnalysis: Move a couple of utility predicates to shared qlpack #14711

merged 2 commits into from Nov 8, 2023

Conversation

aschackmull
Copy link
Contributor

I don't expect this refactor to have any semantic impact.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Nov 7, 2023
@aschackmull aschackmull requested review from a team as code owners November 7, 2023 14:10
MathiasVP
MathiasVP approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI/DCA is happy!

@aschackmull aschackmull merged commit 45ae4ed into github:main Nov 8, 2023
25 of 27 checks passed
@aschackmull aschackmull deleted the shared/rangeutil-share2 branch November 8, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aschackmull @MathiasVP