Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Keep only one framework reference nuget package in standalone #14707

Merged
merged 2 commits into from Nov 8, 2023
Merged

C#: Keep only one framework reference nuget package in standalone #14707

merged 2 commits into from Nov 8, 2023

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Nov 7, 2023 •
edited

No description provided.

@github-actions github-actions bot added the C# label Nov 7, 2023
@tamasvajk
Copy link
Contributor Author

tamasvajk commented Nov 8, 2023 •
edited

The DCA analysis shows compilation error increases in:

  • luciana-pereira/fhir-server - this seems to be transient, see https://github.com/github/codeql-csharp-team/issues/397
  • OpenKH/OpenKh - this seems to be a valid issue. This repo targets netstandard2.0, net6.0, net472. There's a 22% increase in compilation errors.
  • akkadotnet/akka.net, 5% increase
  [001] Found .NET Core/Framework DLLs in NuGet packages at /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netcore.app.ref. Not adding installation directory.
  [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netframework.referenceassemblies.net471/1.0.3
  [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/netstandard.library/2.0.3/lib/netstandard1.0
  • NLog/NLog, 9% increase.
  [001] Found .NET Core/Framework DLLs in NuGet packages at /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netcore.app.ref. Not adding installation directory.
  [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netframework.referenceassemblies.net472/1.0.3
  [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/netstandard.library/2.0.3/lib/netstandard1.0

@tamasvajk tamasvajk marked this pull request as ready for review November 8, 2023 10:06
@tamasvajk tamasvajk requested a review from a team as a code owner November 8, 2023 10:06
michaelnebel
michaelnebel approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍

Yes, so this happens exactly when different target frameworks are used in different project files (if it was in the same file the assets logic would "catch" this and only use one)?

@tamasvajk tamasvajk merged commit 4ae35d1 into github:main Nov 8, 2023
16 checks passed
@tamasvajk tamasvajk deleted the standalone/framework-nuget-1 branch November 8, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamasvajk @michaelnebel