JavaScript/Python/Ruby: Improve alert message for */weak-cryptographic-algorithm.
#14603
+231
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thm`. Specifically, we add a link to the location where the cryptographic algorithm is configured, which can be far away from its use.
Comment on lines
+16
to
+27
| from Cryptography::CryptographicOperation operation, string msgPrefix | ||
| where | ||
| algorithm = operation.getAlgorithm() and | ||
| // `Cryptography::HashingAlgorithm` and `Cryptography::PasswordHashingAlgorithm` are | ||
| // handled by `py/weak-sensitive-data-hashing` | ||
| algorithm instanceof Cryptography::EncryptionAlgorithm and | ||
| ( | ||
| exists(Cryptography::EncryptionAlgorithm algorithm | algorithm = operation.getAlgorithm() | | ||
| algorithm.isWeak() and | ||
| msgPrefix = "The cryptographic algorithm " + operation.getAlgorithm().getName() | ||
| msgPrefix = "The cryptographic algorithm " + algorithm.getName() | ||
| ) | ||
| or | ||
| operation.getBlockMode().isWeak() and msgPrefix = "The block mode " + operation.getBlockMode() | ||
| select operation, msgPrefix + " is broken or weak, and should not be used." | ||
| select operation, "$@ is broken or weak, and should not be used.", operation.getInitialization(), | ||
| msgPrefix |
Check warning
Code scanning / CodeQL
Consistent alert message Warning
de2b219
to
104700f
Compare
aibaars
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alert message now contains a link to the location where the algorithm was configured, which may be in a different file from the alert location.
The library changes needed to make this work are not conceptually difficult, but quite spread out. I don't understand the affected libraries very well, so I may well have botched a few of the updates. Feedback from the respective maintainers is highly welcome!
I had a quick look at the corresponding queries for Java and C++, and they already seem to link to the right location, so I didn't change anything there. I'm not sure what the query is called for C#, Go and Swift.