Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Fix dataflow consistency error due to missing class scope #14590

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Python: Fix dataflow consistency error due to missing class scope #14590

wants to merge 2 commits into from
+62 −70

Conversation

RasmusWL
Copy link
Member

No description provided.

@RasmusWL RasmusWL requested a review from a team as a code owner October 25, 2023 13:06
@RasmusWL RasmusWL added the no-change-note-required This PR does not need a change note label Oct 25, 2023
tausbn
tausbn approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I'm assuming the large number of new consistency failures were simply hidden before, as there was no enclosing scope for the source or target of these source steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RasmusWL @tausbn