C#: Update DependencyManager logic to exclude commented out references. #14665
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
reviewed
Nov 3, 2023
It was motivated by our integration tests, but it doesn't seem to be that uncommon (I am pretty sure I have done stuff like that in the past myself :-) ). Also searching on GitHub using |
Let's keep them. If we see they don't work for some reason, we'll remove them. |
tamasvajk
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the DependencyManager we do some processing of eg.
PackageReferenceand other content.However, in some cases this might be commented out.
That is, the dependency manager shouldn't detect that we have a package dependency when it comes across something like
as this is commented out.