Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Update README.md #14574

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Swift: Update README.md #14574

wants to merge 2 commits into from

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 24, 2023

Turned the warning at the top into a warning box.

Made the section headers consistent.

I was going to add a new section, but I realized it belongs somewhere else. :)

Turned the warning at the top into a warning box.

Made the section headers consistent.

I was going to add a section, but I realized it belongs somewhere else.  :)
@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Oct 24, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner October 24, 2023 09:13
swift/README.md Outdated
@@ -1,12 +1,11 @@
# Swift on CodeQL

## Warning
> [!WARNING]
> The Swift CodeQL package is an experimental and unsupported work in progress.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's no longer the case, I suggest we pick up wording from this page, and maybe adding the link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Updated.

Change the Warning to a Note and rephrase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation no-change-note-required This PR does not need a change note Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants